Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On startup log subcomponent versions #80

Merged
merged 3 commits into from
Jul 15, 2016
Merged

Conversation

djs55
Copy link
Collaborator

@djs55 djs55 commented Jul 14, 2016

To make understanding bug reports easier, the log output will now contain the versions of

  • uwt
  • hvsock
  • hostnet

Signed-off-by: David Scott <dave.scott@docker.com>
Signed-off-by: David Scott <dave.scott@docker.com>
Signed-off-by: David Scott <dave.scott@docker.com>
@djs55
Copy link
Collaborator Author

djs55 commented Jul 14, 2016

@yomimono @samoht @avsm any objections to this wonderful PR? :)

@samoht
Copy link
Member

samoht commented Jul 14, 2016

LGTM

@dbuenzli is it possible to watermak using more complex strategies (instead of calling opam config subst + sed manually?)

@dbuenzli
Copy link

Currently the best you can use is String (see docs).

Now the problem with this is that to define the value with the result of a program invocation, you'd need to call this on each pkg.ml invocation.

I know I had at a certain point Value of unit -> (string, R.msg) result) in the design but I'm not sure why I eventually left it out. If you feel this can be useful file an issue.

@djs55 djs55 merged commit 843e417 into moby:master Jul 15, 2016
@djs55 djs55 deleted the more-versions branch July 15, 2016 09:49
@samoht samoht mentioned this pull request Jul 15, 2016
avsm pushed a commit to avsm/vpnkit that referenced this pull request May 5, 2017
CI: Also test building with github enabled
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants