xunit reporter should use process.stdout.write instead of console.log #1068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
travisjeffery
pushed a commit
that referenced
this pull request
Dec 12, 2013
xunit reporter should use process.stdout.write instead of console.log
|
This breaks work mocha in browser. |
travisjeffery
added a commit
that referenced
this pull request
Dec 23, 2013
|
What's the use case to run xunit in the browser without some way to dump the results to a file like mocha-phantomjs is doing? |
|
We want to run tests using both selenium and real browser. Due to the need of working inside browser we can not use mocha-selenium. We have some workaround to dump xunit report through selenium. But really, xunit and test runs in browser. |
|
now it doesn't have newlines either |
|
OK since all the tests passed, I assumed it wasn't a requirement for it to run in outside of Node.js. Tests for those reporters needing to run in the browser would help. |
jeffparsons
added a commit
to jeffparsons/mocha
that referenced
this pull request
Jan 6, 2014
Falls back to `console.log` if `process.stdout` is unavailable. Fixes mochajs#1068. (This also seems to have picked up a completely unrelated change to another file that hadn't yet made it into the mocha.js snapshot.)
jonnyreeves
added a commit
to jonnyreeves/mocha
that referenced
this pull request
Dec 14, 2015
Fixes mochajs#1674; provides support *much* needed for [mocha-phantomjs](https://github.com/nathanboktae/mocha-phantomjs) (see [mochajs#133](nathanboktae/mocha-phantomjs#133), [mochajs#220](nathanboktae/mocha-phantomjs#220), etc). Maintains support for running the XUnit reporter in a browser (unlike the previously reverted PR mochajs#1068). ping @alemangui, @nathanboktae Thanks all.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple change that fixes nathanboktae/mocha-phantomjs#114 and makes it more consistent with other formatters that should not have formatting like
json.