Would you be open to adding sinon.js to the project?

[adomokos]

I need to spy or stub on some of the functions I am trying to test. Can I add sinon.js as a dependent project to mocha?

[tj]

nope, much like the assertion libs there's little reason to include them directly

[tj]

plus stubs/mocks/spies are incredibly easy just by swapping out functions no need for libs :D

[tj]

it would be nice to add more to the wiki though I started this page https://github.com/visionmedia/mocha/wiki/Spies

[adomokos]

Yup, I did see that. I was thinking something that we could use in development, but you don't need to package with mocha when you release it.

I started with swapping the functions, but I am too spoiled with a good spy framework like sinon.

[tj]

I really really really rarely "spy", IMO at that point you're not really testing APIs

[adomokos]

What if it's an external dependency, like console.error?

[tj]

I dont think we need it really

[adomokos]

ok, thanks!

[tj]

open to it but I still think that most cases people use spies are really not testing much other than the spy logic itself haha which isn't so useful

[tj]

haha once again im terrible at reading. I thought you were initially asking to add sinon to mocha in general. I still dont think we need it but yeah my bad!!

[adomokos]

no worries, thanks!