fix-panic #72
Merged
fix-panic #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixed runtime panic in server/internal/circ/pool.go occurring on 32-bits architectures caused by misalignment of BytesPool struct members. golang/go#36606 (comment)
Pull Request Test Coverage Report for Build 2186201474
💛 - Coveralls |
|
Good catch @BoskyWSMFN - I caused this in the v1.2.0 update. We need to find an easy way to check 32bit runtime... Merging and releasing v1.2.1 👍🏻 Thank you! |
The easiest way is raspbian as far as I can see. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed runtime panic in
server/internal/circ/pool.gooccurring on 32-bits architectures caused by misalignment ofBytesPoolstruct members.golang/go#36606 (comment)