Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Instead of waiting for the writing buffer to have enough space, skip writing and return an error #97

Merged
merged 2 commits into from
Sep 10, 2022
Merged

Instead of waiting for the writing buffer to have enough space, skip writing and return an error #97

merged 2 commits into from
Sep 10, 2022

Conversation

alexsporn
Copy link
Contributor

This fixes #95

@mochi-co
Copy link
Collaborator

mochi-co commented Sep 2, 2022

Let's discuss this in #95 and come to a complete solution before we approve 👍🏻

@mochi-co mochi-co added bug Something isn't working enhancement New feature or request discussion Something to be discussed labels Sep 2, 2022
@coveralls
Copy link

Pull Request Test Coverage Report for Build 3023006869

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.0008%) to 97.807%
Totals Coverage Status
Change from base Build 2981579440: -0.0008%
Covered Lines: 2765
Relevant Lines: 2827
💛 - Coveralls

@mochi-co mochi-co merged commit f22b827 into mochi-mqtt:master Sep 10, 2022
mochi-co pushed a commit that referenced this pull request Sep 11, 2022
Revert "Merge pull request #97 from alexsporn/fix/writer-full"
0dbebbc 
This reverts commit f22b827, reversing
changes made to b2fc287.
@mochi-co mochi-co mentioned this pull request Sep 11, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mochi-co mochi-co mochi-co approved these changes

Assignees
No one assigned
Labels
bug Something isn't working discussion Something to be discussed enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Slow clients slow down the whole broker
3 participants
@alexsporn @mochi-co @coveralls