Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement CognitoAuth #15

Merged
merged 3 commits into from
Jun 15, 2021
Merged

Implement CognitoAuth #15

merged 3 commits into from
Jun 15, 2021

Conversation

mochipon
Copy link
Owner

Candy House has released great iOS/Android SDKs under the MIT license. In addition, they have published rich documentation compared to the Web API.

This PR implements CognitoAuth that can replace WebAPIAuth, although its use is not recommended. This authentication method requires not only API_KEY, but also CLIENT_ID. After authentication, pysesame3 communicates with the service in the way implemented in the SDK.

Again, this authentication method is not recommended. This only copies a small part of the SDK. At the moment, this authentication method is not available by default. If you want to use it, you need to specify it explicitly when you install this library: pip install pysesame3[cognito].

@codecov
Copy link

codecov bot commented Jun 15, 2021

Codecov Report

Merging #15 (b41e952) into main (9a74886) will decrease coverage by 5.43%.
The diff coverage is 82.45%.

Impacted file tree graph

@@             Coverage Diff             @@
##              main      #15      +/-   ##
===========================================
- Coverage   100.00%   94.56%   -5.44%     
===========================================
  Files            8        8              
  Lines          275      368      +93     
===========================================
+ Hits           275      348      +73     
- Misses           0       20      +20     
Impacted Files Coverage Δ
pysesame3/lock.py 78.94% <42.85%> (-21.06%) ⬇️
pysesame3/auth.py 92.30% <90.69%> (-7.70%) ⬇️
pysesame3/cloud.py 100.00% <100.00%> (ø)
pysesame3/const.py 100.00% <100.00%> (ø)
pysesame3/device.py 100.00% <100.00%> (ø)
pysesame3/history.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a74886...b41e952. Read the comment docs.

@mochipon mochipon merged commit 5208a51 into main Jun 15, 2021
@mochipon mochipon deleted the feat/sdk-like branch June 15, 2021 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant