Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better babel plugin import integration #17

Merged
merged 14 commits into from
Mar 20, 2018

Conversation

plrthink
Copy link
Collaborator

This change tends to make ibot has better integration with bable-import-plugin, which would help users loading resources on demand. Although we have supported it already, but not perfectly. The reason is we were using named export somewhere in this codebase but bable-plugin-import has the limitation towards this since it can only (on my perspective) find the right entry module witch default export, which means users would right the entire path to import the module they want, both js and css.
That would also be erorr prone because they may forget to import the styles.

So I changed the export on the surface to the default export, this change is a break change cause it requires users to tweak their code some cases like form component.

And shame on me, I broke the SEMVER again for publishing the wrong version to the wild.

…l resolve the right module and requires the essential styles, no more precise import which means simple code.
@plrthink plrthink requested a review from ethantw March 11, 2018 16:54
@plrthink
Copy link
Collaborator Author

啊 失误了 应该手动来 rebase

@plrthink plrthink merged commit a8d4a30 into master Mar 20, 2018
@plrthink plrthink deleted the better-babel-plugin-import-integration branch March 20, 2018 07:06
@iny7 iny7 mentioned this pull request Mar 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants