-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code cov on releases #493
Code cov on releases #493
Conversation
Current coverage is 87.87%
|
- ./gradlew ciBuild release | ||
- TRAVIS_MESSAGE="$(git log --format=%B -n 1)" | ||
- ./gradlew ciBuild | ||
- if [[ $TRAVIS_MESSAGE != *"[ci skip-release]"* ]] ; then ./gradlew release; fi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can be a oneliner I believe
if [[ $(git log --format=%B -n 1) != *"[ci skip-release]"* ]] ; then ./gradlew release; fi
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The git log command was from a travis issue as there is an intent to add the new environment variable. The command is kinda magic, so naming the variable makes it imo easier to comprehend.
From the changes I don't understand why the code coverage is mentioned in this PR. Code coverage should be triggered by any travis build. |
Yes it is triggered on every Travis build. However, as explained in #465 the delivery drones creates a release commit with ci skip. Therefore Travis is not triggered and codecov fails, see the first comment on this PR. To prevent a release loop on travis, instead of a full ci skip it only does a ci skip-release. This is handled in the .travis.yml. |
Is this PR still relevant? If yes, is it ready to be merged? |
Yes it is still relevant. Releases do not trigger code cov and therefore result in empty comparisons. |
I will merge it, if it seems to break stuff (I do not expect it to) then I will revert. |
Enhancement for mockito#493.
Enhancement for mockito#493.
Enhancement for mockito#493.
Enhancement for mockito#493.
Enhancement for mockito#493.
Enhancement for mockito#493.
Enhancement for mockito#493.
Enhancement for mockito#493.
@TimvdLippe continuing our discussion on PR #980 - can this fix be backported to |
@mureinik Back then we did not divert yet with |
Releases are now triggering CI builds to generate the code coverage reports.
An example of a normal build can be found at https://travis-ci.org/mockito/mockito/builds/143765346#L334-L374
An example of a build ignored as the commit message contained
[ci skip-release]
can be found at https://travis-ci.org/mockito/mockito/builds/143765834#L311-L314Fixes #465