Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/Ability to use multiple RCPT TO commands during one session #126

Merged
merged 1 commit into from
Nov 14, 2022

Conversation

bestwebua
Copy link
Member

@bestwebua bestwebua commented Nov 13, 2022

  • Added ability to use multiple RCPT TO commands during one SMTP session, following RFC 2821 (section 4.1.1.3)
  • Updated configuration, ConfigurationAttr, tests
  • Updated Message, tests
  • Updated handlerRcptto, handlerData, tests
  • Updated main#attrFromCommandLine, tests
  • Updated go.mod version
  • Updated release publisher script
  • Updated CircleCI config
  • Updated project docs, changelog

@bestwebua bestwebua self-assigned this Nov 13, 2022
@bestwebua bestwebua force-pushed the feature/ability-to-use-multiple-rcptto branch 2 times, most recently from 3f9f292 to f4dd910 Compare November 13, 2022 13:48
@codecov-commenter
Copy link

codecov-commenter commented Nov 13, 2022

Codecov Report

Merging #126 (731bbcf) into develop (b701c1f) will not change coverage.
The diff coverage is n/a.

❗ Current head 731bbcf differs from pull request most recent head b396ef0. Consider uploading reports for the commit b396ef0 to get more accurate results

@@            Coverage Diff            @@
##           develop      #126   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           16        16           
  Lines          746       746           
=========================================
  Hits           746       746           
Impacted Files Coverage Δ
cmd/main.go 100.00% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@bestwebua bestwebua linked an issue Nov 13, 2022 that may be closed by this pull request
4 tasks
* Added ability to use multiple RCPTTO commands during one SMTP session, following RFC 2821, section 4.1.1.3
* Updated configuration, ConfigurationAttr, tests
* Updated Message, tests
* Updated handlerRcptto, handlerData, tests
* Updated main#attrFromCommandLine, tests
* Updated go.mod version
* Updated release publisher script
* Updated CircleCI config
* Updated project docs, changelog
@bestwebua bestwebua force-pushed the feature/ability-to-use-multiple-rcptto branch from 731bbcf to b396ef0 Compare November 14, 2022 07:31
@bestwebua bestwebua marked this pull request as ready for review November 14, 2022 07:32
@bestwebua
Copy link
Member Author

bestwebua commented Nov 14, 2022

I suggest to make a new major release of smtpmock after merge of #125. Because both of PR's include breaking changes. Any thoughts guys? @dandare100, @benjamin-rood

@benjamin-rood
Copy link
Collaborator

benjamin-rood commented Nov 14, 2022 via email

@dandare100
Copy link
Contributor

Same here, Agreed

@bestwebua bestwebua merged commit decf20d into develop Nov 14, 2022
@bestwebua bestwebua deleted the feature/ability-to-use-multiple-rcptto branch November 14, 2022 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

[FEATURE] Support multiple RCPT TO addresses on the same session
4 participants