Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix scope for gradient value #51

Merged
merged 1 commit into from
Jul 22, 2020
Merged

fix scope for gradient value #51

merged 1 commit into from
Jul 22, 2020

Conversation

SaraaraS
Copy link
Contributor

  1. Fix and issue where gradientValue could be undefined
  2. Fix the scope on gradientValue and EntryValue so they aren't globals
  3. Update the Readme to link out to the correct version of Uglifyjs

jaylandro
jaylandro approved these changes Jul 22, 2020
View reviewed changes
Copy link

@jaylandro jaylandro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 🙌 🍦

@SaraaraS SaraaraS merged commit 4700e98 into mode:master Jul 22, 2020
@SaraaraS SaraaraS mentioned this pull request Jul 22, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaylandro jaylandro jaylandro approved these changes

@shekinah-smith shekinah-smith Awaiting requested review from shekinah-smith

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SaraaraS @jaylandro