Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Source dir example #2874

Merged
merged 4 commits into from
Mar 1, 2021
Merged

Source dir example #2874

merged 4 commits into from
Mar 1, 2021

Conversation

HansOlsson
Copy link
Collaborator

Closes #2847

eshmoylova
eshmoylova approved these changes Feb 26, 2021
View reviewed changes
Copy link
Member

@eshmoylova eshmoylova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

beutlich
beutlich reviewed Feb 26, 2021
View reviewed changes
Copy link
Member

@beutlich beutlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small remark on consistency: Maybe you could rename Func[12].c to ExternalFunc[12].c to match the other file name ExternalFunc3.c.

maltelenz
maltelenz reviewed Mar 1, 2021
View reviewed changes
chapters/functions.tex Outdated Show resolved Hide resolved
@HansOlsson
Copy link
Collaborator Author

Just a small remark on consistency: Maybe you could rename Func[12].c to ExternalFunc[12].c to match the other file name ExternalFunc3.c.

Actually, that inconsistency is by choice.
I thought that since the different C-files are treated differently (including vs. external compilation) it made sense to name them differently.

@HansOlsson HansOlsson merged commit 41ecf17 into modelica:master Mar 1, 2021
@HansOlsson HansOlsson deleted the SourceDirExample branch March 1, 2021 09:39
@HansOlsson HansOlsson added the M36 For pull requests merged into Modelica 3.6 label Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maltelenz maltelenz maltelenz left review comments

@beutlich beutlich beutlich left review comments

@eshmoylova eshmoylova eshmoylova approved these changes

Assignees
No one assigned
Labels
M36 For pull requests merged into Modelica 3.6
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support source files for external functions - example
4 participants
@HansOlsson @maltelenz @beutlich @eshmoylova