-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make use of component variability when defining expression variability #3039
Merged
HansOlsson
merged 6 commits into
modelica:master
from
henrikt-ma:use-component-variability
Nov 30, 2021
Merged
Make use of component variability when defining expression variability #3039
HansOlsson
merged 6 commits into
modelica:master
from
henrikt-ma:use-component-variability
Nov 30, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eshmoylova
reviewed
Nov 19, 2021
eshmoylova
approved these changes
Nov 23, 2021
HansOlsson
reviewed
Nov 25, 2021
HansOlsson
reviewed
Nov 26, 2021
Co-authored-by: Hans Olsson <HansOlsson@users.noreply.github.com>
HansOlsson
approved these changes
Nov 29, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
eshmoylova
reviewed
Nov 29, 2021
As suggested by Elena. Co-authored-by: Elena Shmoylova <eshmoylova@users.noreply.github.com>
eshmoylova
approved these changes
Nov 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an addition to #2989, strengthening the role of the component variability definitions and making a stronger connection between the two variability concepts.