Clarify each #3314
Merged
Clarify each #3314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henrikt-ma
reviewed
Dec 13, 2022
henrikt-ma
reviewed
Dec 13, 2022
henrikt-ma
requested review from
henrikt-ma and
qlambert-pro
and removed request for
henrikt-ma
HansOlsson
commented
Dec 14, 2022
Co-authored-by: Henrik Tidefelt <henrikt@wolfram.com>
|
Was it a mistake to merge this without any approving review? |
If there were no approving review it seems like an error. However, unless the reviewers see any problem I don't think we need to revert it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3052
Note that it changed "in array declaration/modification" to "inside array declaration or modification of array", as "array modification" seemed a bit unclear.