Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix result file name in Run.mos script #3618

Merged
merged 1 commit into from
Aug 24, 2020
Merged

Fix result file name in Run.mos script #3618

merged 1 commit into from
Aug 24, 2020

Conversation

beutlich
Copy link
Member

In addition to #3614, which was merged too early.

@beutlich beutlich added the L: Resources Issue addresses Modelica/Resources (excl. C-Sources) label Aug 17, 2020
@beutlich beutlich added this to the MSL4.1.0 milestone Aug 17, 2020
@beutlich beutlich self-assigned this Aug 17, 2020
DagBruck
DagBruck reviewed Aug 17, 2020
View reviewed changes
Copy link
Contributor

@DagBruck DagBruck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still believe the best solution is to leave the filename unchanged.

@beutlich
Copy link
Member Author

I still believe the best solution is to leave the filename unchanged.

For maint/4.0.x, yes. For master we can change the name.

@beutlich beutlich requested review from DagBruck, tobolar and HansOlsson and removed request for tobolar, HansOlsson and DagBruck August 21, 2020 18:14
HansOlsson
HansOlsson approved these changes Aug 21, 2020
View reviewed changes
Copy link
Contributor

@HansOlsson HansOlsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok!

@beutlich beutlich removed the request for review from tobolar August 24, 2020 16:52
@beutlich beutlich merged commit 39285d3 into modelica:master Aug 24, 2020
@beutlich beutlich deleted the fix-result-file-name branch August 24, 2020 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DagBruck DagBruck DagBruck approved these changes

@HansOlsson HansOlsson HansOlsson approved these changes

Assignees

@beutlich beutlich

Labels
L: Resources Issue addresses Modelica/Resources (excl. C-Sources)
Projects
None yet
Milestone
MSL4.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@beutlich @HansOlsson @DagBruck