Improvements to line models #3833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dietmarw
added
enhancement
beutlich
reviewed
Jun 10, 2021
| @@ -337,9 +336,9 @@ its current can be accessed for plotting.</p> | |||
| <p>In the picture of the segment can be seen, that a single segment is asymmetric. | |||
| Connecting such asymmetric segments in a series forces also an asymmetric multi line. | |||
| To get a symmetric model which is useful for coupling and which guaranties the same pin properties, | |||
There was a problem hiding this comment.
- Sometimes it is called
symmetric, sometimessymmetrical. Could be made consistent, To get ...could be changed toTo design ...as proposed in the other comment.
Co-authored-by: Thomas Beutlich <modelica@tbeu.de>
Co-authored-by: Thomas Beutlich <modelica@tbeu.de>
|
@dietmarw It's still a draft. Is it ready for review? |
|
@christiankral These are your changes so you can decide if it is still draft or not ;-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are the changes that @christiankral accidentally committed to the backport PR #3818.
I've marked them as draft for now.