Have different sources for different units to help unit-checking. #4051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HansOlsson
added
the
L: ModelicaTest
|
(Testing of Modelica.Blocks, I assume library officer for "Test" also can handle "ModelicaTest") |
beutlich
reviewed
Jun 4, 2024
Comment on lines
+1389
to
+1396
| connect(to_litre.u, cosine9.y) | ||
| annotation (Line(points={{48,110},{41,110}}, color={0,0,127})); | ||
| connect(cosine12.y, to_gps.u) | ||
| annotation (Line(points={{41,-10},{48,-10}}, color={0,0,127})); | ||
| connect(cosine11.y, to_bar.u) | ||
| annotation (Line(points={{41,30},{48,30}}, color={0,0,127})); | ||
| connect(cosine10.y, to_kWh.u) | ||
| annotation (Line(points={{41,70},{48,70}}, color={0,0,127})); |
There was a problem hiding this comment.
Minor comment: Can I please ask for sorting by cosine instance name and having the cosine connector as first argument of the connect statement?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By using different sources for different conversions we make it clear that they are independent and also help unit-checking.
These were the only such obvious unit-issues in the test-suite.