-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for #3971 #4074
Fix for #3971 #4074
Conversation
Co-authored-by: Thomas Beutlich <modelica@tbeu.de>
Hm... I did suggest that solution, and it makes sense - but it is a bit inconsistent since for non-clocked signals Modelica.Blocks.Interfaces.PartialNoise is inherited by Modelica.Blocks.Noise.UniformNoise which is unlimited. If we think that is a problem we could have PartialRangeLimitedNoise as a separate base-class containing these parameters in both cases. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this makes sense, and have suggested an alternative if we want to have more consistent interfaces.
Yes, we can do that; I have been aware of this alternative when pushing the current proposal. My thinking was along the lines, that such an additional base-class for even more variety can be done if there is any need at hand (hence, users request); I don't want to model too much that likely is never used as far as we can see. |
Fix for #3971: Moved the parameters into the interface. I double checked that all interface implementations (subclasses) in fact introduce both parameters; their defaults have been the same.