Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If the limits don't make sense use linear interpolation in Modelica.Fluid.Utilities.regfun3 #4157

Merged
merged 1 commit into from
Jun 28, 2023

Conversation

HansOlsson
Copy link
Contributor

See #4128 (comment)

I'm not saying that it fully corrects the issues with regfun3 - but at least it is a clear improvement that avoids the common failures.
Closes #3758
(Yes, I re-ran that example - the jump is gone).

Note I'm not saying that it completes the investigation of regfun3 and thus I don't see it as closing #4128
It could be that after a proper investigation and correction that regfun3 will never generate out-of-bounds values for those variables.

@HansOlsson HansOlsson added the L: Fluid Issue addresses Modelica.Fluid (excl. Dissipation) label Jun 14, 2023
Copy link
Contributor

@casella casella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely an improvement, if not the definitive one. If it solves the original issue, go for it.

@TManikantan TManikantan added this to the MSL4.1.0 milestone Jun 27, 2023
@casella
Copy link
Contributor

casella commented Jun 28, 2023

@HansOlsson this should resolve #3758. Did you test that when you made the commit? If so, we can close this ticket as well as #3758.

@HansOlsson
Copy link
Contributor Author

@HansOlsson this should resolve #3758. Did you test that when you made the commit? If so, we can close this ticket as well as #3758.

(I assume you mean close by merging, right?
Yes, I tested that it resolved the jump in #3758

However, I think that someone should still investigate regfun3 in general (at some point in time).
That's why I proposed that this closes #3758 but leaving #4128 open.

@casella casella merged commit 5e8b62c into modelica:master Jun 28, 2023
@HansOlsson HansOlsson deleted the Patchregfun3 branch September 11, 2023 13:26
@beutlich beutlich added the bug Critical/severe issue label Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Critical/severe issue L: Fluid Issue addresses Modelica.Fluid (excl. Dissipation)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Jump in Modelica.Fluid.Pipes.BaseClasses.WallFriction.LaminarAndQuadraticTurbulent.massFlowRate_dp_staticHead
5 participants