-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add massFraction function to Media library #4243
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- implemented massFraction for partialPureSubstance - implemented massFraction for PartialMixtureMedium - added 3 test cases for ModeliceTest covering pure / reduced mixture / non-reduced misture
dzimmer
changed the title
- added partial massFraction to partialMedium
add massFraction function to Media library
Jan 3, 2024
beutlich
reviewed
Jan 4, 2024
beutlich
changed the title
add massFraction function to Media library
Add massFraction function to Media library
Jan 4, 2024
Accepted suggestion Co-authored-by: Thomas Beutlich <modelica@tbeu.de>
MartinOtter
approved these changes
Jan 8, 2024
tobolar
reviewed
Jan 8, 2024
hubertus65
approved these changes
Jan 9, 2024
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a second pull request replacing #3825 which attempted to resolve #3650.
#3825 should be discarded and archived consequently.
This pull request is based on the most recent master of the MSL and I have taken the critic of #3825 into account:
The added function is till called massFraction not massFractions for the following reasons:
The following changes are included in the pull request.
massFraction
forpartialPureSubstance
massFraction
forPartialMixtureMedium