-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing macro definitions #4282
Conversation
Should we add the undefines to the other header files as well? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With this, I was able to build it cleanly (on Linux) with our vendor-provided ModelicaUtilities.h
.
Should all of the define stuff be removed from .CI/Test/ModelicaUtilities.h
, to more closely resemble a vendor-provided ModelicaUtilities.h
, and avoid accidental reliance on these defines?
This comment in the ModelicaUtilities.h
is not correct:
A generic C-implementation of these functions cannot be given,
because it is tool dependent how strings are output in a
window of the respective simulation tool. Therefore, only
this header file is shipped with the Modelica Standard Library.
since it is not shipped. To be fair, this PR didn't touch that part.
It's updated now.
I prefer to have it as is. After all, it is test code only.
From what I checked, it is fine as it is. |
Closes #4280.