Fix illegal ModelicaTest.Media.TestOnly.WaterIF97_dewEnthalpy #4429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ModelicaTest.Media.TestOnly.WaterIF97_dewEnthalpy used the partial medium Modelica.Media.Water.WaterIF97_fixedregion, which is not allowed by the MLS, so it is not valid Modelica code. This PR replaces the medium model with the non-partial package Modelica.Media.Water.StandardWater
casella
requested review from
maltelenz,
AHaumer,
hubertus65,
GallLeo and
arunkumar-narasimhan
|
After accepting it, this should be back-ported to maint/4.1.0 |
beutlich
added
the
L: ModelicaTest
maltelenz
reviewed
Jun 24, 2024
arunkumar-narasimhan
approved these changes
Jun 27, 2024
|
@maltelenz if you can approve this, we can merge it in. Thanks! |
|
@maltelenz the only knowledgeable people on Media that are available now are myself and @arunkumar-narasimhan. @rfranke resigned. @hubertus65 also is very competent, but he delegated to Arun because he doesn't have the time. So, I need someone else to rubber-stamp our PRs 😄 |
beutlich
changed the title
|
Backported to maintenance branch by #4437 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ModelicaTest.Media.TestOnly.WaterIF97_dewEnthalpy used the partial medium Modelica.Media.Water.WaterIF97_fixedregion, which is not allowed by the MLS, so it is not valid Modelica code.
This PR replaces the medium model with the non-partial package Modelica.Media.Water.StandardWater