Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adaptation of the CAN demos to the latest fmi-ls-bus header version #108

Merged
merged 1 commit into from
Mar 1, 2024

Conversation

bmenne-dspace
Copy link
Contributor

No description provided.

Copy link
Contributor

@ClemensB ClemensB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but I think it is more clear to use the v1.0.0-alpha.1 tag instead of the revision since that's possible now.

@@ -9,7 +9,7 @@

# Repository to fetch the LS-BUS headers from
LS_BUS_REPO = 'modelica/fmi-ls-bus'
LS_BUS_REV = '7d277c5d55b294f69d61627b1968f39d7ff9fc4d'
LS_BUS_REV = '6c4b6b27e17046e439a653adafd7e9019925d4bf'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since there is an alpha tag now, we could also just use "v1.0.0-alpha.1" here to reflect that the demos target that.

@@ -9,7 +9,7 @@

# Repository to fetch the LS-BUS headers from
LS_BUS_REPO = 'modelica/fmi-ls-bus'
LS_BUS_REV = '7d277c5d55b294f69d61627b1968f39d7ff9fc4d'
LS_BUS_REV = '6c4b6b27e17046e439a653adafd7e9019925d4bf'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above.

@ClemensB ClemensB self-requested a review February 22, 2024 05:41
@bmenne-dspace bmenne-dspace merged commit 6797b5b into main Mar 1, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants