Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed sentence about list attribute name #1551

Merged
merged 3 commits into from
Nov 3, 2021
Merged

fixed sentence about list attribute name #1551

merged 3 commits into from
Nov 3, 2021

Conversation

make-ing
Copy link
Contributor

@make-ing make-ing commented Oct 27, 2021 •
edited
Loading

Checklist

N/A Re-generated schema figures.

The sentence prior to the change did not make sense:

All lists defined in the fmi3ModelDescription.xsd XML schema file have a string attribute name to a list element.

I think the to a list element comes from an earlier version of the senctence which is not required anymore. I suggest this version of the sentence:

All lists defined in the fmi3ModelDescription.xsd XML schema file have a string attribute called name.

@make-ing make-ing changed the title Make ing patch 1 fixed sentence about list attribute name Oct 27, 2021
@andreas-junghanns
Copy link
Contributor

@pmai : Can you validate? I have not the slightest idea what this sentence is supposed to say... sorry.

TorstenBlochwitz
TorstenBlochwitz approved these changes Nov 3, 2021
View reviewed changes
Copy link

@TorstenBlochwitz TorstenBlochwitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@andreas-junghanns andreas-junghanns merged commit d620f94 into modelica:master Nov 3, 2021
@make-ing
Copy link
Contributor Author

make-ing commented Nov 3, 2021

Nice to see this community is working fast and well. Thanks fro accepting my PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreas-junghanns andreas-junghanns andreas-junghanns approved these changes

@TorstenBlochwitz TorstenBlochwitz TorstenBlochwitz approved these changes

@pmai pmai Awaiting requested review from pmai

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@make-ing @andreas-junghanns @TorstenBlochwitz