Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change Table1 solver/scheduler use #1610

Merged
merged 2 commits into from
Dec 30, 2021
Merged

Change Table1 solver/scheduler use #1610

merged 2 commits into from
Dec 30, 2021

Conversation

andreas-junghanns
Copy link
Contributor

No description provided.

@andreas-junghanns andreas-junghanns added this to the v3.0 milestone Dec 29, 2021
@andreas-junghanns andreas-junghanns self-assigned this Dec 29, 2021
@andreas-junghanns andreas-junghanns linked an issue Dec 29, 2021 that may be closed by this pull request
Solver in SE? #1607
Closed
@andreas-junghanns andreas-junghanns requested review from MBlesken and t-sommer and removed request for MBlesken December 29, 2021 11:31
@andreas-junghanns andreas-junghanns merged commit 5ff4763 into modelica:master Dec 30, 2021
MBlesken
MBlesken reviewed Jan 3, 2022
View reviewed changes
Copy link
Contributor

@MBlesken MBlesken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andreas-junghanns did you consider adding a "solver" to figure 3 as well?

@andreas-junghanns
Copy link
Contributor Author

@andreas-junghanns did you consider adding a "solver" to figure 3 as well?

We did and it is clear we should not: here in figure three, we do say "Scheduled" Execution: the Scheduler should be prominent and is part of the API (like the Solver in ME). IN CS, we don´t know what is inside, that is why we added both there.
This makes it also symmetrical between ME-CS and SE-CS.

@MBlesken
Copy link
Contributor

MBlesken commented Jan 3, 2022

We did and it is clear we should not: here in figure three, we do say "Scheduled" Execution: the Scheduler should be prominent and is part of the API (like the Solver in ME). IN CS, we don´t know what is inside, that is why we added both there.
This makes it also symmetrical between ME-CS and SE-CS.

Agreed. I like it.

@beutlich beutlich removed the request for review from t-sommer January 4, 2022 05:45
@andreas-junghanns andreas-junghanns deleted the Table1_solver branch January 4, 2022 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MBlesken MBlesken MBlesken left review comments

@chrbertsch chrbertsch chrbertsch approved these changes

Assignees

@andreas-junghanns andreas-junghanns

Labels
None yet
Projects
None yet
Milestone
v3.0
Development

Successfully merging this pull request may close these issues.

Solver in SE?
3 participants
@andreas-junghanns @MBlesken @chrbertsch