Clarify multiple Clock ticks per Event Mode for different Clock types #1937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masoud-najafi
approved these changes
Apr 17, 2024
chrbertsch
approved these changes
May 21, 2024
There was a problem hiding this comment.
FMI Design Webmeeting:
Klaus: we have contratiction for aperiodic clocks. Either we disallow an interval 0, or allow triggering more than once.
Markus Suevern: There could be a use case for interval 0, e.g. in LS-BUS. Interval 0 means: "stay in event mode".
Torsten: We should merge it, it is a contradiction. We overlooked this case.
Klaus: We should clearly mention this in the release notes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1916
Removes the contradicting statement that aperiodic Clocks are not allowed to be activated more than once per Event Mode.