Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monster statuette owner message when not in a house #1417

Closed
vexyl opened this issue Jun 27, 2023 · 1 comment · Fixed by #1832
Closed

Monster statuette owner message when not in a house #1417

vexyl opened this issue Jun 27, 2023 · 1 comment · Fixed by #1832
Labels
wontfix This will not be worked on

Comments

@vexyl
Copy link
Contributor

vexyl commented Jun 27, 2023

When attempting to activate a monster statuette when you're not in a house you get the system message "You must be the owner to use this."

MonsterStatuette.cs:

        public bool IsOwner(Mobile mob) => BaseHouse.FindHouseAt(this)?.IsOwner(mob) == true;

        public override void OnDoubleClick(Mobile from)
        {
            if (IsOwner(from))
            {
                var onOffGump = new OnOffGump(this);
                from.SendGump(onOffGump);
            }
            else
            {
                from.SendLocalizedMessage(502691); // You must be the owner to use this.
            }
        }

It's only checking if the player is an owner, and not 2 separate checks if they are in a house and if they are the owner of that house.

@kamronbatman
Copy link
Contributor

This isn't meant to be used outside of a house. So the next question is, should we modify it so GMs can place them anywhere, and suppress player manipulation failure messages?

kamronbatman added a commit that referenced this issue Jun 11, 2024
### Summary
- Generalizes the On/Off toggle items concept
- Updates the OnOffGump so it is static
- Standardizes OnOff items so they can be used by staff


### Notes
Decided to not fix #1417 because it is not clear that the clilocs or errors are for that purpose. Can't test this on OSI anyways.
@kamronbatman kamronbatman added the wontfix This will not be worked on label Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants