-
-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mobile trigger hard-coded to 1024px #73
Comments
Matsuuu
added a commit
to Matsuuu/rocket
that referenced
this issue
Feb 22, 2021
Matsuuu
added a commit
to Matsuuu/rocket
that referenced
this issue
Feb 22, 2021
daKmoR
pushed a commit
that referenced
this issue
Feb 23, 2021
daKmoR
pushed a commit
that referenced
this issue
Feb 23, 2021
This has been addressed on the commit here , and will likely be deployed in the next Rocket version (if not already :) ) |
it's released now 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Because RocketDrawer.js seems to be hard-coded to 1024px per this line:
this.useOverlayMediaQuery = '(max-width: 1024px)';
then my understanding is that I am forced to make all my
@media
queries for mobile break on the same value, else I get weird results?It would be more ideal if RocketDrawer were configurable such that
<rocket-drawer something="700">
were possible, giving me the ability to set my mobile trigger media queries on a different value for different themes.The text was updated successfully, but these errors were encountered: