Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mobile trigger hard-coded to 1024px #73

Closed
petecarapetyan opened this issue Feb 11, 2021 · 2 comments
Closed

Mobile trigger hard-coded to 1024px #73

petecarapetyan opened this issue Feb 11, 2021 · 2 comments

Comments

@petecarapetyan
Copy link

Because RocketDrawer.js seems to be hard-coded to 1024px per this line:

this.useOverlayMediaQuery = '(max-width: 1024px)';

then my understanding is that I am forced to make all my @media queries for mobile break on the same value, else I get weird results?

It would be more ideal if RocketDrawer were configurable such that <rocket-drawer something="700"> were possible, giving me the ability to set my mobile trigger media queries on a different value for different themes.

@Matsuuu
Copy link
Contributor

Matsuuu commented Feb 24, 2021

This has been addressed on the commit here , and will likely be deployed in the next Rocket version (if not already :) )

@daKmoR
Copy link
Member

daKmoR commented Mar 8, 2021

it's released now 👍

@daKmoR daKmoR closed this as completed Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants