Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(test-runner): unifying visual-written representation 'skip' tests… #2585

Closed
wants to merge 30 commits into from
Closed

fix(test-runner): unifying visual-written representation 'skip' tests… #2585

Changes from all commits
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
8beff63
fix(test-runner): unifying visual-written representation ‘skip’ tests…
oscarmarina Dec 22, 2023
e37a1aa
ci: fix node tests
thepassle Jan 3, 2024
a878b86
ci: use workspaces to run node tests
thepassle Jan 3, 2024
4b2897a
chore: format
thepassle Jan 3, 2024
deb2be1
chore: remove unused ci stuff, other stuff runs in ci already now
thepassle Jan 3, 2024
6f687e8
chore: test logging for windows
thepassle Jan 3, 2024
a7d6aac
chore: fix paths maybe?
thepassle Jan 3, 2024
b64eb89
chore: fix copy tests
thepassle Jan 3, 2024
b56b4cf
retrigger ci because it hangs
thepassle Jan 3, 2024
e9f0e44
ci: trigger again
thepassle Jan 3, 2024
7b57bab
fix tests
thepassle Jan 3, 2024
ca40e10
fix dep
thepassle Jan 3, 2024
b82daf7
trigger ci
thepassle Jan 4, 2024
f32f2e5
increase timeout in browser tests
koddsson Jan 4, 2024
15cab67
increase timeout for CI
koddsson Jan 4, 2024
d2dc1f3
set test suite wide timeout in hmr browser tests
koddsson Jan 4, 2024
766b380
chore: skip test
thepassle Jan 4, 2024
7141976
chore: only run node tests on windows
thepassle Jan 4, 2024
9bb94c5
ci: remove browserstack/saucelabs, they are largely unused
thepassle Jan 4, 2024
c414d61
ci: separate node and browser tests
thepassle Jan 4, 2024
02b6105
ci: align reporters across all packages
thepassle Jan 4, 2024
d0b5db6
ci: split up linting
thepassle Jan 4, 2024
1497bbd
update CI task names
koddsson Jan 5, 2024
4989179
update node versions in CI tasks
koddsson Jan 5, 2024
2efef9a
update actions packages
koddsson Jan 5, 2024
a110642
update more actions actions
koddsson Jan 5, 2024
5b8a0a6
update a node version
koddsson Jan 5, 2024
5cd69a3
update job names
koddsson Jan 5, 2024
6446e2a
move windows tests into node test file
koddsson Jan 5, 2024
9dc6e3c
Merge branch 'modernweb-dev:master' into unifying-visual-written-skip…
oscarmarina Jan 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/test-runner/src/reporter/summaryReporter.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,8 @@ export function summaryReporter(opts: Options): Reporter {
let args: ReporterArgs;
let favoriteBrowser: string;

function log(logger: Logger, name: string, passed: boolean, prefix = ' ', postfix = '') {
const sign = passed ? green('✓') : red('𐄂');
function log(logger: Logger, name: string, passed: boolean, skipped:boolean, prefix = ' ', postfix = '') {
const sign = skipped ? dim('-') : passed ? green('✓') : red('𐄂');
if (flatten) logger.log(`${sign} ${name}${postfix}`);
else logger.log(`${prefix} ${sign} ${name}`);
}
Expand All @@ -44,7 +44,7 @@ export function summaryReporter(opts: Options): Reporter {
) {
const browserName = browser?.name ? ` ${dim(`[${browser.name}]`)}` : '';
for (const result of results?.tests ?? []) {
log(logger, result.name, result.passed, prefix, browserName);
log(logger, result.name, result.passed, result.skipped, prefix, browserName);
}

for (const suite of results?.suites ?? []) {
Expand Down
Loading