Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: windows tests #2712

Merged
merged 2 commits into from
Apr 23, 2024
Merged

fix: windows tests #2712

merged 2 commits into from
Apr 23, 2024

Conversation

thepassle
Copy link
Member

What I did

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Apr 23, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 195109a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

bashmish
bashmish reviewed Apr 23, 2024
View reviewed changes
packages/rollup-plugin-html/test/rollup-plugin-html.test.ts
'assets/image-a.png',
'assets/image-d.png',
'image-a.png',
'image-d.png',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is output changed?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because we're comparing the name (which is 'image-a.png'), instead of the fileName (which is 'assets/image-a.png')

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you have image-a.png twice now, I thought the check of the path was needed

@thepassle thepassle merged commit 834a383 into master Apr 23, 2024
7 checks passed
@thepassle thepassle deleted the fix/windows-tests branch April 23, 2024 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bashmish bashmish bashmish left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thepassle @bashmish