fix(storybook-framework-web-components): watch code changes and auto-reload by default #2735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…reload by default
🦋 Changeset detectedLatest commit: 589bad6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
watch: trueto enable auto-reload by defaultWe implemented the baseline for auto-reload here #2482
But I overlooked the fact that
watch: truewasn't set by default.It should be, because it's expected of the Storybook to have this behavior by default, e.g.
@storybook/web-components-vitehas it.If we make a stable HMR implementation and test it extensively, we can in the future enable that instead by default (this is what frameworks presets are for, also the one I patch here). For now it's just a simple page reload.