fix(MFFileMgmt): remove string_to_file_path #1759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpbonelli
force-pushed
the
fix-mffilemgmt
branch
from
4905c1d
to
2684f18
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a bug in Python's
ntpath.join(the Windows implementation ofos.path.join) which adds an extra leading slash to UNC paths. This is causing a test failure forMFFileMgmt.string_to_file_path, as far as I can tell only for Python>=3.11.1.The
string_to_file_pathmethod seems unnecessary: the tests just assert that the arg value equals the return value. This PR removes the method.