fix(contours): use nan for mpl contour masks on structured grids #1766
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1615 switched
PlotMapView.contour_array()
from tricontours to standard Matplotlib contours for structured grids, but did not update the masking mechanism — in the meantime themasked_values
argument was ignored for structured grids and only used for vertex/unstructured grids, which still use tricontours.This PR adds support for structured grid contour masks, converting any
masked_values
tonp.nan
before passing the masked array tocontour
/contourf
.