Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(load_node_mapping): add sim parameter to populate Mf6Splitter._model_dict #1828

Merged
merged 2 commits into from
Jun 13, 2023
Merged

Conversation

jlarsen-usgs
Copy link
Contributor

  • update test_save_load_node_mapping
  • fix MFSimulation.model_names, return an iterable list instead of dict keys object

* update test_save_load_node_mapping
* fix MFSimulation.model_names, return an iterable list instead of dict keys object
@codecov
Copy link

codecov bot commented Jun 13, 2023

Codecov Report

Merging #1828 (4af8133) into develop (2fa3d65) will increase coverage by 0.0%.
The diff coverage is 85.1%.

@@           Coverage Diff           @@
##           develop   #1828   +/-   ##
=======================================
  Coverage     72.1%   72.1%           
=======================================
  Files          255     255           
  Lines        56050   56092   +42     
=======================================
+ Hits         40446   40496   +50     
+ Misses       15604   15596    -8     
Impacted Files Coverage Δ
flopy/mf6/utils/model_splitter.py 69.1% <84.9%> (+0.6%) ⬆️
flopy/mf6/modflow/mfsimulation.py 65.6% <100.0%> (+1.2%) ⬆️

@jlarsen-usgs
Copy link
Contributor Author

PR is still in progress. I found that we need to save additional data to the JSON file for reconstruct_array() to work properly.

@jdhughes-usgs jdhughes-usgs merged commit 22ef330 into modflowpy:develop Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants