Remove extra interpretations to fflags #28
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flags should be passed as expected by the compiler. Currently, pymake's checking/adding '-' to each fflag token is problematic for (e.g.) Intel, which can have flags with spaces like
-warn unused
. Also, compiler flags are always case-sensitive, so there's no need to do.upper()
on these. (Also, these spaces need to be split in cmdlist to work correctly with Popen, which is done here too.)This is a minor breaking change, in that external tools that use pymake will need to ensure the fflags have dashes, where they would normally be expected by the compiler.
There are many other changes included here (got carried away):
fflags
can either be a str'-flag1 -flag two'
or list['-flag1', '-flag two']
-double_size
to-double-size
, and/real_size
to/real-size
-real-size 64
instead of-r8
(does same thing)flag_available()
; document some limitations in docstring/flag:1
rather than-flag 1
)