Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invoking LayrryLauncher with no args should print usage and quit #81

Closed
aalmiray opened this issue Feb 2, 2021 · 5 comments · Fixed by #85
Closed

Invoking LayrryLauncher with no args should print usage and quit #81

aalmiray opened this issue Feb 2, 2021 · 5 comments · Fixed by #85
Labels
enhancement New feature or request released Issue has been released
Milestone
1.0.0.Beta1

Comments

@aalmiray
Copy link
Contributor

aalmiray commented Feb 2, 2021

Currently it prints an exception and quits

Exception in thread "main" com.beust.jcommander.ParameterException: The following option is required: [--layers-config]
	at com.beust.jcommander.JCommander.validateOptions(JCommander.java:388)
	at com.beust.jcommander.JCommander.parse(JCommander.java:357)
	at com.beust.jcommander.JCommander.parse(JCommander.java:335)
	at org.moditect.layrry.launcher.LayrryLauncher.launch(LayrryLauncher.java:50)
	at org.moditect.layrry.launcher.LayrryLauncher.main(LayrryLauncher.java:41)
@aalmiray aalmiray added the enhancement New feature or request label Feb 2, 2021
@gunnarmorling
Copy link
Member

gunnarmorling commented Feb 2, 2021 via email

@gunnarmorling
Copy link
Member

gunnarmorling commented Feb 2, 2021 via email

@aalmiray
Copy link
Contributor Author

aalmiray commented Feb 2, 2021

Though to be fully compatible with all possible configured parsers the code should iterate over every available LayersConfigParser instance and check if "layers." + parser.getPreferredFileExtension() exists in the current launch directory.

@aalmiray aalmiray changed the title Invoking LayrryLauncher with no args shuld print usage and quit Invoking LayrryLauncher with no args should print usage and quit Feb 2, 2021
@aalmiray aalmiray mentioned this issue Feb 2, 2021
Merged
@gunnarmorling
Copy link
Member

gunnarmorling commented Feb 2, 2021 via email

@aalmiray aalmiray mentioned this issue Feb 2, 2021
Merged
aalmiray added a commit to aalmiray/layrry that referenced this issue Feb 2, 2021
@aalmiray
Issue moditect#81. Print supported config formats
af6d9eb
aalmiray added a commit to aalmiray/layrry that referenced this issue Feb 2, 2021
@aalmiray
Issue moditect#81. Handle implicit layers config file
4ac3edf
aalmiray added a commit to aalmiray/layrry that referenced this issue Feb 2, 2021
@aalmiray
Issue moditect#81. Tweak error message when layer config file is not …
89b5e56 
…found
aalmiray added a commit to aalmiray/layrry that referenced this issue Feb 2, 2021
@aalmiray
Issue moditect#81. Fix code formatting
dd7eaa2
aalmiray added a commit to aalmiray/layrry that referenced this issue Feb 2, 2021
@aalmiray
Issue moditect#81. Print supported config formats
d70a0be
aalmiray added a commit to aalmiray/layrry that referenced this issue Feb 2, 2021
@aalmiray
Issue moditect#81. Handle implicit layers config file
121bb88
aalmiray added a commit to aalmiray/layrry that referenced this issue Feb 2, 2021
@aalmiray
Issue moditect#81. Tweak error message when layer config file is not …
fa051eb 
…found
aalmiray added a commit to aalmiray/layrry that referenced this issue Feb 2, 2021
@aalmiray
Issue moditect#81. Fix code formatting
a7b9d2f
aalmiray added a commit to aalmiray/layrry that referenced this issue Feb 2, 2021
@aalmiray
Issue moditect#81. Add example file/urls to usage descriptions
2deda25
gunnarmorling pushed a commit that referenced this issue Feb 2, 2021
@aalmiray @gunnarmorling
Issue #81. Print supported config formats
1b96781
gunnarmorling pushed a commit that referenced this issue Feb 2, 2021
@aalmiray @gunnarmorling
Issue #81. Handle implicit layers config file
1951f74
gunnarmorling pushed a commit that referenced this issue Feb 2, 2021
@aalmiray @gunnarmorling
Issue #81. Tweak error message when layer config file is not found
02a462f
gunnarmorling pushed a commit that referenced this issue Feb 2, 2021
@aalmiray @gunnarmorling
Issue #81. Fix code formatting
bdcefc8
gunnarmorling pushed a commit that referenced this issue Feb 2, 2021
@aalmiray @gunnarmorling
Issue #81. Add example file/urls to usage descriptions
0d45a21
@gunnarmorling gunnarmorling added this to the 1.0.0.Beta1 milestone Feb 8, 2021
@github-actions
Copy link
Contributor

Released in v1.0.0.Alpha2 -> https://github.com/moditect/layrry/releases/tag/v1.0.0.Alpha2

@github-actions github-actions bot added the released Issue has been released label Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request released Issue has been released
Projects
None yet
Milestone
1.0.0.Beta1
Development

Successfully merging a pull request may close this issue.

Launcher args handling aalmiray/layrry
2 participants
@aalmiray @gunnarmorling