Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

STM32 DAC Platform Driver #420

Merged
merged 1 commit into from
Jun 19, 2020
Merged

STM32 DAC Platform Driver #420

merged 1 commit into from
Jun 19, 2020

Conversation

mcbridejc
Copy link
Contributor

Implement a basic synchronous DAC driver for the STM32.

Closes #113.

salkinium
salkinium requested changes Jun 18, 2020
View reviewed changes
Copy link
Member

@salkinium salkinium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed you need to limit the module's availability, since the DAC implementations differ a little.

src/modm/platform/dac/stm32/module.lb Show resolved Hide resolved
src/modm/platform/gpio/stm32/pin.hpp.in Outdated Show resolved Hide resolved
salkinium
salkinium approved these changes Jun 18, 2020
View reviewed changes
Copy link
Member

@salkinium salkinium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@salkinium
Copy link
Member

(rebased and squashed, will merge when the CI passes)

@salkinium salkinium merged commit 78d18f6 into modm-io:develop Jun 19, 2020
@salkinium salkinium mentioned this pull request Jul 5, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@salkinium salkinium salkinium approved these changes

Assignees
No one assigned
Labels
feature 🚧
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DAC API
2 participants
@mcbridejc @salkinium