Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix: Deleting messages for thread recipients #3057

Closed
wants to merge 1 commit into from

Conversation

lorenzo132
Copy link
Member

reverted beb73d8
this causes messages to not delete in dm channels

reverted modmail-dev@beb73d8
this causes messages to not delete in dm channels
@Erisa
Copy link

Erisa commented Jun 27, 2021

Echoing my thoughts from #3041:
It's a great hotfix for now, however I have noticed one time where deleting a message said that it failed when it in fact succeeded.

A good longterm solution going forward would be what @Jerrie-Aries mentioned and appears to have committed to some dev fork. (Jerrie-Aries@25aa1d4)

@fourjr fourjr changed the title Update thread.py Hotfix: Deleting messages for thread recipients Aug 7, 2021
@fourjr fourjr linked an issue Aug 7, 2021 that may be closed by this pull request
@fourjr
Copy link
Collaborator

fourjr commented Aug 7, 2021

@Jerrie-Aries's solution will be used instead. (v3.10.0-dev5)

@fourjr fourjr closed this Aug 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] delete does not delete message for recipient
3 participants