Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Fallback Channel Method Bugs #3002

Closed
Coolguy3289 opened this issue Apr 19, 2021 · 3 comments
Closed

[BUG] Fallback Channel Method Bugs #3002

Coolguy3289 opened this issue Apr 19, 2021 · 3 comments
Labels
approved bug This is a confirmed bug staged Staged for next version

Comments

@Coolguy3289
Copy link
Contributor

Describe the bug
Categories usually have a max channel limit of 50, this is checked in thread.py however there is a bug in the Discord API where a category having 49 channels is returning "Category has reached the maximum number of channels" causing the thread creation to fail since the check to trigger the fallback category functionality is contingent on the category having 50 channels.

Bot Info
Bot version (check with @modmail about): 3.9.3
Host method (Heroku, self-host, etc): Self-Host

Error Logs
http://haste.thegamingcorner.net/imelisejom.sql
After some extra Debug Logging
http://haste.thegamingcorner.net/igelukovez.sql

@Coolguy3289 Coolguy3289 added the maybe: bug An unconfirmed bug label Apr 19, 2021
Coolguy3289 added a commit to Coolguy3289/modmail that referenced this issue Apr 19, 2021
Addresses modmail-dev#3002
Will add a 1 channel buffer to the check to account for Discord API bugs preventing the category from actually reaching 50 channels.
@Coolguy3289
Copy link
Contributor Author

Coolguy3289 commented Apr 20, 2021

After making the change, I'm now seeing this issue:
image
The bot is creating categories with only one channel, and not filling them

@Jerrie-Aries
Copy link
Contributor

That's kinda weird. It's like the bot didn't save the new 'fallback_category_id' or something.

@Coolguy3289
Copy link
Contributor Author

Well it did, and it used that category, but once it was filled up, it didn't migrate/update the config for the new one. Rather, it did, created the new thread and seems to have just dumped it for the old value. I've tried removing the config value and it's doing the same thing.

@Coolguy3289 Coolguy3289 changed the title [BUG] Discord Max Channels Per Category Bug [BUG] Fallback Channel Method Bugs Apr 22, 2021
@fourjr fourjr added approved bug This is a confirmed bug staged Staged for next version and removed maybe: bug An unconfirmed bug labels Apr 25, 2021
@fourjr fourjr closed this as completed Apr 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved bug This is a confirmed bug staged Staged for next version
Projects
None yet
Development

No branches or pull requests

3 participants