This repository has been archived by the owner on May 10, 2023. It is now read-only.
fix rrdtool 1.5.x compatibility #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonioo
reviewed
Sep 19, 2016
| for vindex, value in enumerate(row.findall('v')): | ||
| if value.text == 'NaN': | ||
| result[vindex]['data'].append({'x': timestamp, 'y': 0}) | ||
| else: | ||
| result[vindex]['data'].append( | ||
| {'x': timestamp, 'y': float(value.text)} | ||
| ) | ||
| timestamp +=step |
in version 1.5.x the --showtime option was removed, thus no timestamps in the row elements. But we can easily calculate them using the start timestamp and the step size. That option seems to be back in rrdtool 1.6 but nobody knows in what lts distribution 1.5 will land, this soloution should work regardless of the of the version, no checking necessary.
Arvedui
force-pushed
the
rrdtool-1.5.x
branch
from
8e91c90
to
aec40f5
Compare
|
Ah sorry missed that one. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in version 1.5.x the --showtime option was removed, thus no timestamps
in the row elements.
But we can easily calculate them using the start timestamp and the step
size.
That option seems to be back in rrdtool 1.6 but nobody knows in
what lts distribution 1.5 will land, this soloution should work
regardless of the of the version, no checking necessary.