Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Searching through installed content while on a page other than 1 will break results #798

Closed
RubenRME opened this issue Oct 9, 2023 · 0 comments · Fixed by #800
Closed

Searching through installed content while on a page other than 1 will break results #798

RubenRME opened this issue Oct 9, 2023 · 0 comments · Fixed by #800
Labels
bug Something isn't working

Comments

@RubenRME
Copy link

RubenRME commented Oct 9, 2023

Describe the bug

When going through the paged (😔) list of installed mods/content of an instance, search results will completely break if you're not on the first page.

Steps to reproduce

  1. Open an instance
  2. Go to a page other than 1
  3. Type something in the searchbar you know would give results
  4. Observe

Expected behavior

Show actual results

System information

Windows 11 Pro
Modrinth App v0.5.4 (there's no way to actually check this in the app btw)

Additional context

Modrinth_App_2023-10-09_22-35-46
@RubenRME RubenRME added the bug Something isn't working label Oct 9, 2023
@BlueZeeKing BlueZeeKing mentioned this issue Oct 10, 2023
Merged
Geometrically added a commit that referenced this issue Jul 4, 2024
@Geometrically
Shaderpack support (#798)
97ecb0a 
* Shader support PR

* Make search page work

* Fix env showing

* Make moderation look reasonable

* Fix search for shaders
Geometrically added a commit that referenced this issue Oct 16, 2024
@Geometrically
Fix high memory usage during search (#798)
f53b6b5 
* Fix high memory usage during search

* Fix settings lag

* Fix clippy + fmt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Search pagination fix BlueZeeKing/theseus
1 participant
@RubenRME