Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Theseus: Profile Management #8

Closed
8 tasks done
Geometrically opened this issue Feb 20, 2022 · 0 comments · Fixed by #17
Closed
8 tasks done

Theseus: Profile Management #8

Geometrically opened this issue Feb 20, 2022 · 0 comments · Fixed by #17
Assignees
@enderger

Comments

@Geometrically
Copy link
Member

Geometrically commented Feb 20, 2022 •
edited by enderger
Loading

Profiles are a complex and intricate system. This issue is split up into multiple sub tasks.

  • Base "global state" for profiles. Essentially, when the application starts, all of the profiles should be loaded into memory
  • Profile Settings, Java Install, Memory, Custom Java Args, Game Window Resolution settings, Custom Commands (see MMC)
  • Profile Metadata: Instance location, mod loader version, MC version
  • Profile icons (part of metadata), but should be able to be preselected from a directory included with the launcher, or set to a custom icon. If set to a custom icon, copy it to the profile directory
  • Way to query a profile + save changes from the frontend
  • Methods for profiles to be launched and stopped
  • Way for game version and loader version to be changed
  • Way for profiles to be listed for frontend display

For the global state - take a look at how the setttings singletons are implemented in theseus. The way profile management should be very similar to how the settings singleton is structured.
@Geometrically Geometrically added this to the Initial Launcher Release milestone Feb 20, 2022
This was referenced Feb 20, 2022
Closed
Closed
@enderger enderger mentioned this issue Feb 23, 2022
Merged
Geometrically pushed a commit that referenced this issue Jul 4, 2024
@Prospector
Start omorphia 2 (#8)
0faa24d
Geometrically pushed a commit that referenced this issue Jul 4, 2024
@Mysterious-Dev @brawaru
Add translation keys for collections (#1496)
52b2993 
* Begin Work

* Add more common messages

* Work on modal

* Add more keys

* Add keys for icon buttons

* Add more keys

* Handle error keys

* Add more keys

* Add more keys

* Edit fields keys

* Finish (almost)

* Finish work for collection page

* Dashboard Nav stack & Format

* WIP

* Move some messages to common

* Finish work

* Format

* Reorganization

* Fix some mistake

* add common collections label

* Add collections label key to default layout

* Make title and description reactive (#8)

---------

Co-authored-by: Sasha Sorokin <10401817+brawaru@users.noreply.github.com>
Geometrically added a commit that referenced this issue Oct 19, 2024
@Geometrically
Auto doing fixes (#8)
6c628af
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@enderger enderger

Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Initial draft of profile metadata format & CLI enderger/theseus
2 participants
@Geometrically @enderger