Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(theseus): dont call MacCssFix constantly #1269

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

ToBinio
Copy link
Contributor

@ToBinio ToBinio commented Jul 8, 2024

This PR reworks MacCssFix to be a composable instead of a mixin since

  1. mixins shouldn't be used any more.
  2. the function was called constantly, I don't know how mixins work but I would guess it was called for every component being created.

note:
please verify that it still works as expected (don't know why it should not) but I don't have a mac so yea...

reopen of #1205

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant