perf(thesues): multi thread file hashing and increase buffer size #1272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
not necessary since 0.8 doesnt block anymore |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for me, this PR increases the updating speed by around 2.5x, from 7.8s to 2.8s
This is useful since the update_projects() locks the credentials that are needed by the settings page
this means for the first 8 seconds I can't open the settings page.
and this will just get worse with more/ bigger instances
maybe it would be good to move to a faster hashing algorithm, not sure
note:
the reason I even investigated this was that when running in debug mode the time isn't 8 seconds its more like 5 minutes...
reopen of #1210