Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #449

Merged
merged 10 commits into from
Aug 5, 2023
Merged

fixes #449

merged 10 commits into from
Aug 5, 2023

Conversation

thesuzerain
Copy link
Contributor

@thesuzerain thesuzerain commented Aug 4, 2023

Fixes #420
Fixes #422
Fixes #429
Fixes #433
Fixes #436 (improved bad-folder error msg and also now imports will auto-find the launcher's folder if it exists in the normal location)
Fixes #437
Fixes #438 (animation doesn't play on linux)
Fixes #440
Fixes #443 (note that it now plays after the modrinth loading circle/state initialization, as it does a check to the settings to see if onboarding is complete)
Fixes #448 (silence warning)
Fixes #452
Fixes #453
Fixes #456
Fixes #458

Fixes .mrpacks not having icons (now if no icon is provided on an import, icon.png will be used if it exists). See discussion on #455 and in discord

@thesuzerain thesuzerain marked this pull request as ready for review August 4, 2023 02:39
@thesuzerain thesuzerain marked this pull request as draft August 4, 2023 17:05
@thesuzerain thesuzerain marked this pull request as ready for review August 4, 2023 23:03
@Geometrically Geometrically merged commit a35dd67 into master Aug 5, 2023
6 checks passed
@Geometrically Geometrically deleted the more-bugs branch August 5, 2023 03:33
Geometrically pushed a commit that referenced this pull request Oct 16, 2024
* Move to SPDX licenses

Found a way to do this without breaking API compat, so here it is, instead of waiting for v3

Resolves MOD-129
Resolves #396

* License URL updates

* what was I thinking

* Do a thing

* Add open source filter

* Remove dead imports

* Borrow

* Update 20220910132835_spdx-licenses.sql

* Add license text route

* Update migration

* Address comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment