Profile bindings #55
Merged
Profile bindings #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Geometrically
requested changes
Mar 28, 2023
Geometrically
requested changes
Mar 30, 2023
theseus/src/api/profile_create.rs
Outdated
| pub async fn profile_create_empty() -> crate::Result<Profile> { | ||
| Ok(profile_create( | ||
| String::from(DEFAULT_NAME), // the name/path of the profile | ||
| String::from("1.8.2"), // the game version of the profile |
There was a problem hiding this comment.
1.8.2 is a weird version IMO. why not 1.19.2 (which works on all platforms now)
There was a problem hiding this comment.
looks like you forgot to change it
theseus/src/launcher/args.rs
Outdated
| @@ -304,24 +299,29 @@ fn parse_arguments<F>( | |||
| where | |||
| F: Fn(&str) -> crate::Result<String>, | |||
| { | |||
| let temporary_replace_char = "\n"; | |||
There was a problem hiding this comment.
what is this used for? since it's used in multiple places as well it should be a constant and moved to the top of the file
…profile-bindings
…profile-bindings
Geometrically
requested changes
Mar 31, 2023
theseus/src/api/profile_create.rs
Outdated
| pub async fn profile_create_empty() -> crate::Result<Profile> { | ||
| Ok(profile_create( | ||
| String::from(DEFAULT_NAME), // the name/path of the profile | ||
| String::from("1.8.2"), // the game version of the profile |
There was a problem hiding this comment.
looks like you forgot to change it
theseus/src/launcher/args.rs
Outdated
| @@ -304,24 +299,29 @@ fn parse_arguments<F>( | |||
| where | |||
| F: Fn(&str) -> crate::Result<String>, | |||
| { | |||
| let temporary_replace_char = "\n"; | |||
Geometrically
approved these changes
Mar 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR with base functionality so we can continue doing bindings + start using them- the actual calling of functions through tauri part is fairly simple.
Currently also trying to get more complex process API functions to be callable (ie: kill process, which might require minor API changes) + make the tauri functions in main.rs be modular, but not necessary for basic PR to start doing bindings
Fixes MOD-311