Beta bugs #562
Merged
Beta bugs #562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
triphora
reviewed
Aug 11, 2023
triphora
approved these changes
Aug 11, 2023
Geometrically
requested changes
Aug 11, 2023
Comment on lines
103
to
119
| .unwrap_or_else(|e| { | ||
| // TODO: remove temporary logging in future update | ||
| if !instance_folder.exists() { | ||
| tracing::warn!( | ||
| "Instance folder does not exist: {}", | ||
| instance_folder.display() | ||
| ); | ||
| return "".to_string(); | ||
| } else { | ||
| tracing::warn!( | ||
| "Could not read existing instance.json at {}: {}", | ||
| instance_folder.display(), | ||
| e | ||
| ) | ||
| }; | ||
| "".to_string() | ||
| }); |
There was a problem hiding this comment.
is this meant to be removed?
There was a problem hiding this comment.
I meant it to be included so that if the person in disc who's bug I couldn't replicate could have a log when they tried to import their profiles that should be importable.
That being said I do have a guess for what the issue was and fixed it, so I can revert this if you prefer
theseus/src/state/mod.rs
Outdated
| @@ -345,27 +345,25 @@ pub async fn init_watcher() -> crate::Result<Debouncer<RecommendedWatcher>> { | |||
| let (mut tx, mut rx) = channel(1); | |||
|
|
|||
| let file_watcher = new_debouncer( | |||
| Duration::from_secs_f32(2.0), | |||
| Duration::from_secs_f32(10.0), | |||
There was a problem hiding this comment.
10 seconds is very long for the profile syning, mods will take forever to add. what was the reason for this change?
There was a problem hiding this comment.
was trying to reduce cpu load on installs, (when many packs are imported one after another). Reverted as I don't think this is the biggest impact change I made
Geometrically
approved these changes
Aug 14, 2023
Geometrically
pushed a commit
that referenced
this pull request
Oct 16, 2024
* Fixed an issue with colliding slugs when modifying a project * Update projects.rs --------- Co-authored-by: triphora <emma@modrinth.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #442 (doesnt entirely remove CPU usage- there are spikes- but drastically improves)
Fixes #467
Fixes #490
Fixes #492
Fixes #499
Fixes #502
Fixes #504 (as long as the options.txt override settings arent selected)
Fixes #506
Fixes #509
Fixes #512
Fixes #518
Fixes #524
Fixes #538
Fixes #519
Fixes #531
Fixes #553
Fixes #554