Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navbar wireup #98

Merged
merged 7 commits into from
Apr 27, 2023
Merged

Navbar wireup #98

merged 7 commits into from
Apr 27, 2023

Conversation

CodexAdrian
Copy link
Contributor

Fixes MOD-370

Copy link
Member

@Geometrically Geometrically left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For breadcrumbs, it makes a lot of sense to me to include the parent page in most cases.

For instances I think it should be Library > Instance Name(or home if you came from home)
For projects I think it should also be contextual, if you came from an instance it can show that you came from there. If you came from browse it shows browse

@Geometrically Geometrically merged commit bda63d5 into master Apr 27, 2023
@Geometrically Geometrically deleted the navbar-wireup branch April 27, 2023 03:19
Geometrically pushed a commit that referenced this pull request Jul 4, 2024
Small button refactor, overflow and popout menus
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants