Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support new NeoForge userdev plugin. #59

Closed
Darkhax opened this issue Nov 14, 2023 · 3 comments
Closed

Support new NeoForge userdev plugin. #59

Darkhax opened this issue Nov 14, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@Darkhax
Copy link
Contributor

Darkhax commented Nov 14, 2023

Is your suggested enhancement related to a problem? Please describe.

Minotaurs automatic detection does not have integration for NeoForge's new userdev plugin.

Describe the solution you'd like

Add the new plugin ID net.neoforged.gradle.userdev to the pluginLoaderMap. Their old plugin ID is still in use so both should be supported for now.

Describe alternatives you've considered

I am currently setting the properties manually.

Additional context

The solution mentioned is the same fix I used in CurseForgeGradle which had the same issue.

When trying to deploy with Minotaur I noticed the NeoForge upload was also missing a game version. Additional changes will likely be needed for this as well.

@Darkhax Darkhax added the enhancement New feature or request label Nov 14, 2023
@Darkhax
Copy link
Contributor Author

Darkhax commented Nov 15, 2023

Thanks for looking into this. The new fix seems to work for the loader, although the game version detection fails.

Caused by: org.gradle.api.GradleException: Failed to upload file to Modrinth! Cannot get property 'MC_VERSION' on extra properties extension as it does not exist
at com.modrinth.minotaur.TaskModrinthUpload.apply(TaskModrinthUpload.java:262)

@triphora triphora reopened this Nov 15, 2023
triphora added a commit that referenced this issue Nov 17, 2023
@triphora
Copy link
Contributor

Let me know if this is still a problem in v2.8.6. I'm unable to get a working NeoForge dev env locally, regardless of whether Minotaur is involved.

@triphora
Copy link
Contributor

triphora commented Dec 3, 2023

Closing since no response, assuming resolved.

@triphora triphora closed this as completed Dec 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

No branches or pull requests

2 participants