Simplify and update build instructions for windows and update docs #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Because of a cryptic vcpkg package download error when using vcpkg on the github CI pipeline, I've reverted the CI instructions to their previous state. They work, so I don't see an urgent need to change them. With this change, the branch should be ready for review. |
- update build worflow to use vcpkg - update build instructions - remove redundant build instructions by linking to the build guides in root from the documentation - update FindXXX.cmake to better handle windows paths - update FindUMFPACK.cmake to include GKlib
ronald-jaepel
force-pushed
the
feature/update_build_windows_and_docs
branch
from
3db5896
to
b6e0569
Compare
|
Also squashed into one commit. |
schmoelder
requested changes
Nov 20, 2023
There was a problem hiding this comment.
Thanks @ronald-jaepel for working on this. I think this greatly improves the build guide! Also good idea to unify the documentation and repo instructions!
I only have some minor comments, mostly they are due to personal preferences but I thought, I'd add them anyways.
ronald-jaepel
force-pushed
the
feature/update_build_windows_and_docs
branch
from
06d5a13
to
e118337
Compare
ronald-jaepel
force-pushed
the
feature/update_build_windows_and_docs
branch
from
e118337
to
6866c25
Compare
|
@schmoelder All requested changes have been addressed. Imo this branch is ready to be merged. |
schmoelder
approved these changes
Dec 2, 2023
|
LGTM! :) |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #130
Current ToDos: