Return inlet concentration instead of first axial cell #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schmoelder
force-pushed
the
feature/fix_inlet_concentration
branch
from
c94075b
to
32cd482
Compare
Merged
sleweke
reviewed
May 10, 2021
| @@ -433,7 +433,7 @@ class GeneralRateModel2D : public UnitOperationBase | |||
| virtual double const* inlet(unsigned int port, unsigned int& stride) const | |||
| { | |||
| stride = _idx.strideColComp(); | |||
| return &_idx.c(_data, 0, port, 0); | |||
| return _data; | |||
There was a problem hiding this comment.
This is not quite correct since it ignores the ports. Instead of
return _data;you should do
return _data + port * _disc.nComp;
sleweke
requested changes
May 10, 2021
sleweke
approved these changes
May 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #55